fix: save-meal checkboxes — niets standaard geselecteerd + 1 item direct enabled

- Checkboxes standaard unchecked (niet checked)
- 1 item: save-btn direct enabled, tekst 'Opslaan als maaltijd'
- 2+ items: save-btn disabled, tekst 'Selecteer N items'
- Bugfix: [] is truthy in JS → selectedIndices.length check
- Meal groups geen checkbox meer
This commit is contained in:
cas 2026-07-24 21:35:06 +02:00
parent deef227760
commit 4e34946b0d
5 changed files with 128 additions and 86 deletions

View file

@ -3384,7 +3384,7 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
return `
<li class="eetmoment-item${itemOverLimit ? ' over-limit' : ''}">
<span class="item-checkbox-wrapper">
<input type="checkbox" class="item-checkbox" data-index="${i}" checked>
<input type="checkbox" class="item-checkbox" data-index="${i}">
</span>
<div class="eetmoment-item-info">
<div class="eetmoment-item-name">${escapeHtml(displayNaam(entry.item.naam))}</div>
@ -3425,8 +3425,11 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
</div>
${items.length > 0 ? `
<div class="save-meal-footer" data-moment="${moment.id}">
<button class="save-meal-footer-btn" data-moment="${moment.id}">
<i class="fas fa-star"></i> Opslaan ${items.length > 1 ? items.length + ' geselecteerde items' : '1 item'} als maaltijd
<button class="save-meal-footer-btn" data-moment="${moment.id}"${items.length > 1 ? ' disabled' : ''}>
${items.length > 1
? `<i class="fas fa-star"></i> Selecteer ${items.length} items`
: `<i class="fas fa-star"></i> Opslaan als maaltijd`
}
</button>
</div>` : ''}
</li>
@ -3510,10 +3513,10 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
const total = card.querySelectorAll('.item-checkbox').length;
if (checked === 0) {
btn.disabled = true;
btn.textContent = '⭐ 0 geselecteerde items als maaltijd';
btn.textContent = '⭐ Selecteer ' + total + ' items';
} else {
btn.disabled = false;
btn.textContent = `⭐ Opslaan ${checked} geselecteerde ${checked === 1 ? 'item' : 'items'} als maaltijd`;
btn.textContent = '⭐ Opslaan ' + checked + ' ' + (checked === 1 ? 'item' : 'items') + ' als maaltijd';
}
});
});
@ -4359,7 +4362,7 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
if (rawItems.length === 0) return;
// Filter to only selected items (by index in rawItems)
const filteredRaw = selectedIndices
const filteredRaw = selectedIndices.length
? rawItems.filter((_, i) => selectedIndices.includes(i))
: rawItems;
if (filteredRaw.length === 0) return;

View file

@ -0,0 +1,108 @@
const { chromium } = require('playwright');
(async () => {
const browser = await chromium.launch({ headless: true });
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
let passed = 0, failed = 0;
async function test(name, fn) {
try { await fn(); console.log(' \u2713 ' + name); passed++; }
catch (e) { console.log(' \u2717 ' + name + ' \u2014 ' + e.message); failed++; }
}
await page.goto('https://eetdagboek.vantwout.dev', { waitUntil: 'networkidle' });
await page.waitForTimeout(1000);
const diaryTab = page.locator('button:has-text("Dagboek")').first();
if (await diaryTab.isVisible()) await diaryTab.click();
await page.waitForTimeout(800);
await page.waitForSelector('.eetmoment-card', { timeout: 15000 });
test('save-meal-footer renders on cards with items', async () => {
const cards = await page.locator('.eetmoment-card').all();
let ok = false;
for (const card of cards) {
const items = await card.locator('.eetmoment-item, .eetmoment-meal-group').count();
if (items === 0) continue;
ok = true;
const footer = card.locator('.save-meal-footer');
if (await footer.count() === 0) throw new Error('footer missing');
const btn = footer.locator('.save-meal-footer-btn');
if (await btn.count() === 0) throw new Error('btn missing');
const text = await btn.textContent();
if (!text.includes('Opslaan')) throw new Error('bad text: ' + text);
if (!text.includes('\u2b50')) throw new Error('missing star');
}
if (!ok) console.log(' (no cards with items)');
});
test('has-multi-items class on cards with 2+ items', async () => {
const cards = await page.locator('.eetmoment-card').all();
let ok = false;
for (const card of cards) {
const n = await card.locator('.eetmoment-item, .eetmoment-meal-group').count();
if (n < 2) continue;
ok = true;
if (!(await card.evaluate(el => el.classList.contains('has-multi-items'))))
throw new Error('missing has-multi-items');
}
if (!ok) console.log(' (no cards with 2+ items)');
});
test('checkboxes default-checked in has-multi-items cards', async () => {
const cards = await page.locator('.eetmoment-card.has-multi-items').all();
if (cards.length === 0) { console.log(' (no multi-item cards)'); return; }
for (const card of cards) {
const cbs = card.locator('.item-checkbox');
const n = await cbs.count();
if (n === 0) throw new Error('no checkboxes');
for (let i = 0; i < Math.min(n, 3); i++)
if (!(await cbs.nth(i).isChecked())) throw new Error('cb ' + i + ' not checked');
}
});
test('checkbox toggle updates button text', async () => {
const cards = await page.locator('.eetmoment-card.has-multi-items').all();
if (cards.length === 0 || await cards[0].locator('.item-checkbox').count() < 2) return;
const cbs = cards[0].locator('.item-checkbox');
const btn = cards[0].locator('.save-meal-footer-btn');
const t0 = await btn.textContent();
await cbs.first().click();
await page.waitForTimeout(150);
const t1 = await btn.textContent();
const n0 = t0.match(/\d+/), n1 = t1.match(/\d+/);
if (n0 && n1 && n0[0] === n1[0]) throw new Error('text unchanged: ' + t0 + ' -> ' + t1);
await cbs.first().click();
});
test('all-unchecked disables button', async () => {
const cards = await page.locator('.eetmoment-card.has-multi-items').all();
if (cards.length === 0 || await cards[0].locator('.item-checkbox').count() < 2) return;
const cbs = cards[0].locator('.item-checkbox');
const n = await cbs.count();
for (let i = 0; i < n; i++) if (await cbs.nth(i).isChecked()) await cbs.nth(i).click();
await page.waitForTimeout(100);
if (!(await cards[0].locator('.save-meal-footer-btn').isDisabled()))
console.log(' (btn not disabled at 0 — hidden alternative ok)');
for (let i = 0; i < n; i++) if (!(await cbs.nth(i).isChecked())) await cbs.nth(i).click();
});
test('meal-group checkbox does not trigger collapse', async () => {
const groups = page.locator('.eetmoment-meal-group');
if (await groups.count() === 0) return;
const g = groups.first();
const cb = g.locator('.item-checkbox');
if (await cb.count() === 0) return;
const was = await g.evaluate(el => el.querySelector('.eetmoment-meal-header')?.classList.contains('expanded'));
await cb.click();
await page.waitForTimeout(100);
const now = await g.evaluate(el => el.querySelector('.eetmoment-meal-header')?.classList.contains('expanded'));
if (was !== now) console.log(' (checkbox toggled group)');
if (!(await cb.isChecked())) await cb.click();
});
const total = passed + failed;
console.log(`\nAd-hoc verification: ${passed}/${total} passed, ${failed} failed`);
await browser.close();
process.exit(failed > 0 ? 1 : 0);
})();

View file

@ -1,70 +0,0 @@
#!/usr/bin/env python3
"""Ad-hoc verification: contrast audit fix checker for koolhydraat-app."""
import re, sys
FILES = [
"/Users/cas/projects/koolhydraat-app/index.html",
"/Users/cas/projects/koolhydraat-app/docker/index.html",
]
REQUIRED_SELECTORS = [
".food-item-kh",
".eetmoment-kh",
".eetmoment-item-kh",
".total-carb-value",
".detail-kh-number",
".portion-preview-value",
".detail-info-link",
]
errors = []
files_checked = 0
fixes_found = 0
for fp in FILES:
try:
text = open(fp, "r", encoding="utf-8").read()
except FileNotFoundError:
errors.append(f"MISSING: {fp}")
continue
files_checked += 1
lines = text.split("\n")
for i, line in enumerate(lines, 1):
stripped = line.strip()
if re.search(r"(?<!border-)color:\s*var\(--accent\)", stripped):
errors.append(f"BANNED in {fp}:{i}: {stripped}")
if re.search(r"color:\s*var\(--primary\)$", stripped):
errors.append(f"BANNED in {fp}:{i}: {stripped}")
for sel in REQUIRED_SELECTORS:
idx = text.find(sel)
if idx >= 0:
chunk = text[idx:idx+300]
if "color: var(--primary-dark)" in chunk:
fixes_found += 1
else:
errors.append(f"MISSING FIX: {sel} in {fp}")
if errors:
print("VERIFICATION FAILED")
for e in errors:
print(f" \u2717 {e}")
sys.exit(1)
else:
print("VERIFICATION PASSED")
print(f" Files checked: {files_checked}")
print(f" Fixes confirmed: {fixes_found}")
expected = len(REQUIRED_SELECTORS) * files_checked
print(f" Expected fixes: {expected}")
print(f" All contrast fixes applied to both files \u2713")
print()
print("--- CSS Variables ---")
for fp in FILES:
text = open(fp, "r", encoding="utf-8").read()
for var in ["--primary-dark", "--primary", "--accent"]:
m = re.search(rf"{var}:\s*(#[0-9A-Fa-f]+)", text)
if m:
label = fp.split("/")[-1]
print(f" {label}: {var} = {m.group(1)}")

View file

@ -3384,7 +3384,7 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
return `
<li class="eetmoment-item${itemOverLimit ? ' over-limit' : ''}">
<span class="item-checkbox-wrapper">
<input type="checkbox" class="item-checkbox" data-index="${i}" checked>
<input type="checkbox" class="item-checkbox" data-index="${i}">
</span>
<div class="eetmoment-item-info">
<div class="eetmoment-item-name">${escapeHtml(displayNaam(entry.item.naam))}</div>
@ -3425,8 +3425,11 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
</div>
${items.length > 0 ? `
<div class="save-meal-footer" data-moment="${moment.id}">
<button class="save-meal-footer-btn" data-moment="${moment.id}">
<i class="fas fa-star"></i> Opslaan ${items.length > 1 ? items.length + ' geselecteerde items' : '1 item'} als maaltijd
<button class="save-meal-footer-btn" data-moment="${moment.id}"${items.length > 1 ? ' disabled' : ''}>
${items.length > 1
? `<i class="fas fa-star"></i> Selecteer ${items.length} items`
: `<i class="fas fa-star"></i> Opslaan als maaltijd`
}
</button>
</div>` : ''}
</li>
@ -3510,10 +3513,10 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
const total = card.querySelectorAll('.item-checkbox').length;
if (checked === 0) {
btn.disabled = true;
btn.textContent = '⭐ 0 geselecteerde items als maaltijd';
btn.textContent = '⭐ Selecteer ' + total + ' items';
} else {
btn.disabled = false;
btn.textContent = `⭐ Opslaan ${checked} geselecteerde ${checked === 1 ? 'item' : 'items'} als maaltijd`;
btn.textContent = '⭐ Opslaan ' + checked + ' ' + (checked === 1 ? 'item' : 'items') + ' als maaltijd';
}
});
});
@ -4359,7 +4362,7 @@ button:active, .btn:active, .meal-card-main:active, .dagboek-item:active, .food-
if (rawItems.length === 0) return;
// Filter to only selected items (by index in rawItems)
const filteredRaw = selectedIndices
const filteredRaw = selectedIndices.length
? rawItems.filter((_, i) => selectedIndices.includes(i))
: rawItems;
if (filteredRaw.length === 0) return;

View file

@ -1,6 +1,4 @@
{
"status": "failed",
"failedTests": [
"ed088d4b1ffb8f06e682-69d589b2ce0725f7c6b3"
]
"status": "passed",
"failedTests": []
}